Better docs for Faker::Food.description #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
requested changes
May 14, 2018
lib/faker/food.rb
Outdated
| def measurement | ||
| fetch('food.measurement_sizes') + ' ' + fetch('food.measurements') | ||
| end | ||
|
|
||
|
|
||
| # Retrieves metric measures |
There was a problem hiding this comment.
@jujulisan shouldn't it be Retrieves metric mesurements?
There was a problem hiding this comment.
Yes, thanks, I'll fix that.
lib/faker/food.rb
Outdated
| def description | ||
| fetch('food.descriptions') | ||
| end | ||
|
|
||
| # Retrieves a ingredient for dishes |
There was a problem hiding this comment.
shouldn't it be Retrieves an ingredient for dishes?
There was a problem hiding this comment.
Yes, thanks, I'll fix that.
vbrazo
force-pushed
the
master
branch
4 times, most recently
from
6394a28
to
d11bd7e
Compare
|
@jujulisan could you also rebase this branch with master and fix the |
vbrazo
approved these changes
Jun 1, 2018
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* better docs for Faker::Food.description * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert docs for Food Class